poorbarcode commented on code in PR #23088:
URL: https://github.com/apache/pulsar/pull/23088#discussion_r1694496438
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -1201,6 +1203,21 @@ public long estimateBacklogSize() {
}
public SubscriptionStatsImpl getStats(GetStatsOptions getStatsOptions) {
+ // So far, there is no case hits this check.
+ if (getStatsOptions.isGetEarliestTimeInBacklog()) {
+ throw new IllegalArgumentException("Calling the sync method
subscription.getStats with"
+ + " getEarliestTimeInBacklog, it may encountered a
deadlock error.");
+ }
+ // The method "getStatsAsync" will be a sync method if the param
"isGetEarliestTimeInBacklog" is false.
+ try {
+ return getStatsAsync(getStatsOptions).get(5, TimeUnit.SECONDS);
Review Comment:
> You just reduce the lock time: 30s -> 5s, and we don't call this sync
method in the pulsar, or maybe the sync method is only used for the unit test.
Can not fully understand this comment, could you explain more details?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
