thetumbled commented on code in PR #23989:
URL: https://github.com/apache/pulsar/pull/23989#discussion_r1967089727
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java:
##########
@@ -178,6 +178,7 @@ public boolean keepAlive(InetSocketAddress remoteAddress,
Request ahcRequest,
}
});
confBuilder.setDisableHttpsEndpointIdentificationAlgorithm(!conf.isTlsHostnameVerificationEnable());
+ confBuilder.setMaxRequestRetry(0);
Review Comment:
Adding some comment on it will be better.
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java:
##########
@@ -373,6 +373,12 @@ public class ClientConfigurationData implements
Serializable, Cloneable {
)
private String dnsLookupBindAddress = null;
+ @ApiModelProperty(
+ name = "maxRetryRequestTimes",
+ value = "The Pulsar admin client max retry request times, default
value is 5"
Review Comment:
Need to illustrate more about this conf.
This configuration works together with following conf:
```
@ApiModelProperty(
name = "connectionTimeoutMs",
value = "Duration of waiting for a connection to a broker to be
established."
+ "If the duration passes without a response from a
broker, the connection attempt is dropped."
)
private int connectionTimeoutMs = 10000;
@ApiModelProperty(
name = "requestTimeoutMs",
value = "Maximum duration for completing a request."
)
private int requestTimeoutMs = 60000;
@ApiModelProperty(
name = "readTimeoutMs",
value = "Maximum read time of a request."
)
private int readTimeoutMs = 60000;
```
The max retry count may be unreachable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
