thetumbled commented on PR #23989: URL: https://github.com/apache/pulsar/pull/23989#issuecomment-2684199598
> > Good catch! I leave some comments. Since this pr aim to fix a bug, could you add a unit test to reproduce the bug that max retry times double the maxRequestRetry in the httpclient's configuration? > > I'm afraid adding corresponding test cases here could be quite challenging. I'm not sure how to validate the service's retry count – perhaps we could verify whether the configuration file is successfully set through test cases. > > The retry logic is specifically implemented in the onFailure(Channel channel, Throwable cause) method of class org.asynchttpclient.netty.channel.NettyConnectListener from async-http-client. > > On a related note, I don't think the retry logic would result in double the attempts. Since the admin-client invokes async-http-client for each request, the actual retry attempts should be the square of the original configured count (n² if n is the configured retry value). Or have you meet this problem in real enviroment? We should be cautious about the so-called bug fix right? what if the real behaviour is correct? IMO, Maybe you can push forward this pip without the reproducer, but the reproducer will be favourable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
