shibd commented on code in PR #23945: URL: https://github.com/apache/pulsar/pull/23945#discussion_r1984953635
########## pip/pip-406.md: ########## @@ -0,0 +1,153 @@ +# PIP-406: Introduce metrics related to dispatch throttled number of times + +# Background knowledge + +## Motivation + +Currently, users can monitor subscription backlogs using the `pulsar_subscription_back_log_no_delayed` metric. +However, if [dispatch throttling](https://pulsar.apache.org/docs/next/concepts-throttling/) is configured at the broker/topic/subscription level, +this metric may not accurately reflect whether the backlog is due to insufficient consumer capacity, as it could be caused by dispatch throttling. + +## Goals + +Introduce metrics to indicate the count of `messages/bytes throttled` for **broker/topic/subscription** level rate limit. +This allows users to write PromQL queries to identify subscriptions with high backlogs but low or no throttling, pinpointing backlogs caused by insufficient consumer capacity. + +## In Scope + +Broker Level: +- Introduce the metric `pulsar_broker_dispatch_throttled_msg_count` to represent the total number of times message dispatching was throttled on a broker due to broker rate limits. Review Comment: Yes, but I think we still need to keep the keyword 'dispatch'. How about the following names? - pulsar_broker_dispatch_throttle_msg_events - pulsar_broker_dispatch_throttle_byte_events -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
