lhotari commented on code in PR #19783:
URL: https://github.com/apache/pulsar/pull/19783#discussion_r2104336802
##########
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java:
##########
@@ -120,6 +123,7 @@ public CompletableFuture<LedgerEntries> readAsync(long
firstEntry, long lastEntr
}
CompletableFuture<LedgerEntries> promise = new CompletableFuture<>();
executor.execute(() -> {
+ touch();
Review Comment:
> Since it may happen, should we use a read-write lock to protect it? Or add
a special log to let us know the issue happened, which is different from other
scenarios?
Well there are a lot of things in Pulsar that might happen and we don't use
defensive programming against all possible scenarios that might happen. In this
case, the probability is extremely low for the scenario to ever happen with
sane configuration values (such as the default 600 seconds).
There are more severe open issues in Pulsar which have been ignored for a
long time, for example the thread safety of topic policy mutations,
https://github.com/apache/pulsar/issues/21303.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
