poorbarcode commented on code in PR #19783:
URL: https://github.com/apache/pulsar/pull/19783#discussion_r2105812141
##########
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java:
##########
@@ -120,6 +123,7 @@ public CompletableFuture<LedgerEntries> readAsync(long
firstEntry, long lastEntr
}
CompletableFuture<LedgerEntries> promise = new CompletableFuture<>();
executor.execute(() -> {
+ touch();
Review Comment:
> In this case, the probability is extremely low for the scenario to ever
happen with sane configuration values (such as the default 600 seconds).
The value can be modified. What do you think is approximately safe to set
this to at least?
> There are more severe open issues in Pulsar which have been ignored for a
long time, for example the thread safety of topic policy mutations,
https://github.com/apache/pulsar/issues/21303.
Rather than complaining, it's better to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
