lhotari commented on code in PR #24359:
URL: https://github.com/apache/pulsar/pull/24359#discussion_r2111484750
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/InflightReadsLimiter.java:
##########
@@ -177,8 +177,10 @@ private synchronized Optional<Handle> internalAcquire(long
permits, Consumer<Han
return Optional.of(new Handle(maxReadsInFlightSize,
handle.creationTime, true));
} else {
if (queuedHandles.size() >= maxReadsInFlightAcquireQueueSize) {
- log.warn("Failed to queue handle for acquiring permits: {},
creationTime: {}, remainingBytes:{}",
- permits, handle.creationTime, remainingBytes);
+ log.warn("Failed to queue handle for acquiring permits: {},
creationTime: {}, remainingBytes:{},"
+ + " maxReadsInFlightAcquireQueueSize:{},
pending-queue-size: {}, please increase broker"
+ + " config
managedLedgerMaxReadsInFlightPermitsAcquireQueueSize",
Review Comment:
`managedLedgerMaxReadsInFlightSizeInMB` config should be mentioned too if
there's a tuning recommendation. Just wondering if the recommendation should be
removed and the log level changed to debug level here to avoid possible
duplicate error logging in RangeEntryCacheImpl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
