lhotari commented on code in PR #24359:
URL: https://github.com/apache/pulsar/pull/24359#discussion_r2111487626
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/InflightReadsLimiter.java:
##########
@@ -223,15 +225,17 @@ private synchronized void timeoutCheck() {
}
private void handleTimeout(QueuedHandle queuedHandle) {
- if (log.isDebugEnabled()) {
- log.debug("timed out queued permits: {}, creationTime: {},
remainingBytes:{}",
- queuedHandle.handle.permits,
queuedHandle.handle.creationTime, remainingBytes);
- }
+ log.warn("timed out queued permits: {}, creationTime: {},
remainingBytes:{}, acquireTimeoutMillis: {}. Please"
+ + " review whether the BK read requests is fast enough or
broker config"
+ + " managedLedgerMaxReadsInFlightSizeInMB and
managedLedgerMaxReadsInFlightPermitsAcquireTimeoutMillis"
+ + " are suitable",
+ queuedHandle.handle.permits, queuedHandle.handle.creationTime,
remainingBytes, acquireTimeoutMillis);
Review Comment:
Does this just cause duplicate logging when it's at warn level since
RangeEntryCacheImpl will log the failure too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
