RobertIndie commented on code in PR #24495:
URL: https://github.com/apache/pulsar/pull/24495#discussion_r2196347916
##########
pulsar-io/kinesis/src/test/java/org/apache/pulsar/io/kinesis/KinesisSourceConfigTests.java:
##########
@@ -160,4 +161,53 @@ public final void missCloudWatchEndpointTest() {
"{\"accessKey\":\"myKey\",\"secretKey\":\"my-Secret\"}");
KinesisSourceConfig.load(map, Mockito.mock(SourceContext.class));
}
-}
+
+ @Test
+ public final void propertiesDefaultTest() {
+ Map<String, Object> map = new HashMap<>();
+ map.put("awsRegion", "us-west-1");
+ map.put("awsKinesisStreamName", "my-stream");
+ map.put("awsCredentialPluginParam",
"{\"accessKey\":\"myKey\",\"secretKey\":\"my-Secret\"}");
+
+ SourceContext sourceContext = Mockito.mock(SourceContext.class);
+ KinesisSourceConfig config = KinesisSourceConfig.load(map,
sourceContext);
+
+ Set<String> properties = config.getPropertiesToInclude();
+ assertEquals(properties.size(), 6);
+ assertTrue(properties.contains("kinesis.shard.id"));
+ assertTrue(properties.contains("kinesis.sequence.number"));
Review Comment:
Should we check all 6 properties existence here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
