Copilot commented on code in PR #24495:
URL: https://github.com/apache/pulsar/pull/24495#discussion_r2196361127
##########
pulsar-io/kinesis/src/main/java/org/apache/pulsar/io/kinesis/KinesisRecordProcessor.java:
##########
@@ -82,16 +85,20 @@ private void checkpoint(RecordProcessorCheckpointer
checkpointer) {
@Override
public void initialize(InitializationInput initializationInput) {
kinesisShardId = initializationInput.shardId();
+ log.info("Initializing KinesisRecordProcessor for shard {}. Config:
checkpointInterval={}ms, numRetries={}, "
+ + "backoffTime={}ms, propertiesToInclude={}",
+ kinesisShardId, checkpointInterval, numRetries, backoffTime,
propertiesToInclude);
}
@Override
public void processRecords(ProcessRecordsInput processRecordsInput) {
log.info("Processing " + processRecordsInput.records().size() + "
records from " + kinesisShardId);
Review Comment:
Consider using parameterized logging instead of string concatenation to
avoid unnecessary string creation when the log level is disabled, e.g.:
log.info("Processing {} records from {}", processRecordsInput.records().size(),
kinesisShardId);
```suggestion
log.info("Processing {} records from {}",
processRecordsInput.records().size(), kinesisShardId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
