poorbarcode commented on PR #24606:
URL: https://github.com/apache/pulsar/pull/24606#issuecomment-3156975044

   > I‘m +1 with the change, but do we need to add tests for the new methods?
   
   I have added the same test cases that call `expireMessages` directly. The 
other case that does not call `expireMessages` directly should be covered by 
the old tests, such as `testDefaultBacklogTTL`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to