lhotari commented on code in PR #24606:
URL: https://github.com/apache/pulsar/pull/24606#discussion_r2257458487
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -84,6 +85,12 @@ public boolean isAutoSkipNonRecoverableData() {
&&
this.cursor.getManagedLedger().getConfig().isAutoSkipNonRecoverableData();
}
+ @Override
+ public CompletableFuture<Boolean> expireMessagesAsync(int
messageTTLInSeconds) {
+ return CompletableFuture.supplyAsync(() ->
expireMessages(messageTTLInSeconds),
+ cursor.getManagedLedger().asyncMigrate().defaultExecutor());
Review Comment:
In https://github.com/apache/pulsar/pull/24606#discussion_r2256253527 you
mentioned using managed ledger executor. calling the `asyncMigration()` method
doesn't return an executor. It runs the `asyncMigration()` method and returns a
`CompletableFuture`. The `CompletableFuture` has a `defaultExecutor` which
returns the default ForkJoinPool by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
