3pacccccc opened a new pull request, #24702: URL: https://github.com/apache/pulsar/pull/24702
### Motivation implemention of [PIP-436](https://github.com/apache/pulsar/pull/24572) ### Modifications - Added ```DecryptFailListener``` interface for consumers to handle messages that cannot be decrypted. - Added ```ReaderDecryptFailListener``` interface for readers with similar functionality. - Extended ```ConsumerBuilder``` and ```ReaderBuilder``` with methods to set these listeners. - Modified consumer implementations (```ConsumerImpl```, ```MultiTopicsConsumerImpl```, ```ZeroQueueConsumerImpl```) to invoke the ```decryptFailListener``` when appropriate. - Modified reader implementations (```ReaderImpl```, ```MultiTopicsReaderImpl```) to support ```readerDecryptFailListener```. - Updated configuration classes (```ConsumerConfigurationData```, ```ReaderConfigurationData```) to include the new listener fields. - Added comprehensive tests to verify: - Configuration validation (e.g., listener cannot be set without message listener) - Listener invocation for encrypted messages - Interaction with existing crypto failure actions - Both consumer and reader implementations ### Verifying this change - [x] Make sure that the change passes the CI checks. <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [x] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/3pacccccc/pulsar/pull/17 <!-- After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
