heesung-sohn commented on code in PR #24311:
URL: https://github.com/apache/pulsar/pull/24311#discussion_r2393064749
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/util/SchemaUtil.java:
##########
@@ -33,7 +33,16 @@
public class SchemaUtil {
+ private static Boolean globalJsr310ConversionEnabled = null;
+
+ public static void setGlobalJsr310ConversionEnabled(Boolean
globalJsr310ConversionEnabled) {
+ SchemaUtil.globalJsr310ConversionEnabled =
globalJsr310ConversionEnabled;
+ }
+
public static boolean getJsr310ConversionEnabledFromSchemaInfo(SchemaInfo
schemaInfo) {
Review Comment:
Please rename this function to "getJsr310ConversionEnabled" as it
additionally checks the global var.
I am ok with exposing `setGlobalJsr310ConversionEnabled` as this seems to be
the only exception that clients need to override. If we have other such global
configs to override, we need to consider adding
"GlobalSchemaOverrideConfiguration" to maintain them in a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
