3pacccccc opened a new pull request, #24858: URL: https://github.com/apache/pulsar/pull/24858
Fixes https://github.com/apache/pulsar/issues/24850 ### Motivation The test ```testReceiveAsyncCompletedWhenClosing``` was experiencing concurrency race conditions that caused flaky test failures. The issue occurred due to unpredictable timing between two operations: - ```consumer.receiveAsync()``` or ```batchReceiveAsync()``` - ```consumer.close()``` #### Expected behavior: - receiveAsync() should happen before close(), allowing the async operation to be properly interrupted by the close. #### Flaky scenario: - When ```close()``` executes before receiveAsync(), the subsequent ```receiveAsync()``` call immediately returns a ```CompletableFuture``` that completes with a ```PulsarClientException``` containing the message **"Consumer already closed"**. This differs from the expected interruption behavior and causes the test assertion to fail. ### Modifications ensure ```consumer.receiveAsync()``` happens before ```consumer.close()``` #### Solution Added proper synchronization using CountDownLatch to ensure: - The async operation (receiveAsync/batchReceiveAsync) starts first - The close() operation executes only after the async operation has begun ### Verifying this change - [x] Make sure that the change passes the CI checks. *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/3pacccccc/pulsar/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
