Denovo1998 commented on code in PR #24858:
URL: https://github.com/apache/pulsar/pull/24858#discussion_r2435738732
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java:
##########
Review Comment:
This test is not so easy to reproduce locally. What if we add countDown in
finally?
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java:
##########
@@ -4032,14 +4032,18 @@ public void testReceiveAsyncCompletedWhenClosing()
throws Exception {
// 1) Test receiveAsync is interrupted
CountDownLatch countDownLatch = new CountDownLatch(1);
new Thread(() -> {
+ CountDownLatch subCoundDownLatch = new CountDownLatch(1);
Review Comment:
type: `subCountDownLatch`
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java:
##########
@@ -4032,14 +4032,18 @@ public void testReceiveAsyncCompletedWhenClosing()
throws Exception {
// 1) Test receiveAsync is interrupted
CountDownLatch countDownLatch = new CountDownLatch(1);
new Thread(() -> {
+ CountDownLatch subCoundDownLatch = new CountDownLatch(1);
Review Comment:
typo: `subCountDownLatch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
