lhotari commented on code in PR #25040:
URL: https://github.com/apache/pulsar/pull/25040#discussion_r2592420966
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java:
##########
@@ -216,7 +210,6 @@ private void
configureAsyncHttpClientConfig(ClientConfigurationData conf, int co
confBuilder.setCookieStore(null);
confBuilder.setUseProxyProperties(true);
confBuilder.setFollowRedirect(false);
- confBuilder.setRequestTimeout(conf.getRequestTimeoutMs());
Review Comment:
it would be more consistent to set this to `requestTimeoutMs`, since this is
how `connectTimeout and ReadTimeout are also handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
