oneby-wang commented on code in PR #25040:
URL: https://github.com/apache/pulsar/pull/25040#discussion_r2592555118
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java:
##########
Review Comment:
@lhotari here
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java:
##########
@@ -216,7 +210,6 @@ private void
configureAsyncHttpClientConfig(ClientConfigurationData conf, int co
confBuilder.setCookieStore(null);
confBuilder.setUseProxyProperties(true);
confBuilder.setFollowRedirect(false);
- confBuilder.setRequestTimeout(conf.getRequestTimeoutMs());
Review Comment:
The `requestTimeoutMs` param is set twice in this method: once via
`confBuilder.setRequestTimeout(conf.getRequestTimeoutMs())` and once via
`confBuilder.setReadTimeout(readTimeoutMs)`. For this reason, I removed the
line `confBuilder.setRequestTimeout(conf.getRequestTimeoutMs())`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
