lhotari commented on PR #25101: URL: https://github.com/apache/pulsar/pull/25101#issuecomment-3686583411
> I read this code. If we mark delete 12:9, next ledger is an empty ledger: 13:-1, seems this method will only move mark delete position to 12:8. If ledger 12 is trimmed, then causing inconsistency. > > I'm wondering if mark delete position with -1 entryId is a valid mark delete position? Seems some codes intend to avoid this. good observations. It seems that there's a lot of code locations where it's hard to determine which is the correct behavior. There seems to be some inconsistency in how things are handled across different parts of the ManagedLedger implementation. I guess we can focus on addressing the test flakiness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
