oneby-wang commented on PR #25101: URL: https://github.com/apache/pulsar/pull/25101#issuecomment-3686361272
> Just wondering if it's already handled by the advanceCursorsIfNecessary method: I read this code. If we mark delete 12:9, next ledger is an empty ledger: 13:-1, seems this method will only move mark delete position to 12:8. If ledger 12 is trimmed, then causing inconsistency. I'm wondering if mark delete position with -1 entryId is a valid mark delete position? Seems some codes intend to avoid this. https://github.com/apache/pulsar/blob/fbab357fdc28992b59512c355ebf06b29eef4f2e/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L3234-L3236 https://github.com/apache/pulsar/blob/fbab357fdc28992b59512c355ebf06b29eef4f2e/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L622-L632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
