oneby-wang commented on PR #25117: URL: https://github.com/apache/pulsar/pull/25117#issuecomment-3723641221
> Could there be any real issue caused by this inconsistency? In continuous consuming, this should rarely happens. I was intened to do this thing: make sure `markDeletePosition` is moved to `nextValidLedger:-1` once the new ledger is created. But as mentioned before, we can not ensure happens-before between `ManagedCursoImplr.asyncMarkDelete()` and `ManagedLedgerImpl.maybeUpdateCursorBeforeTrimmingConsumedLedger()`. Now, I intend to consolidate all the logic for moving the `markDeletePosition` to `nextValidLedger:-1` into the `asyncMarkDelete()` method. Both `maybeUpdateCursorBeforeTrimmingConsumedLedger()` and the ledger trim process can reuse this part of the logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
