oneby-wang commented on PR #25117:
URL: https://github.com/apache/pulsar/pull/25117#issuecomment-3741470454

   Another inconsistent test case is: 
`ManagedLedgerTest.testTrimmerRaceConditionInNonDurableCursor()`.
   
   If we don't move `markDeletedPosition` to `nextValidLedger:-1`, non-durable 
cursor's `markDeletedPosition` will be inconsistent with ledger data. See 
assert: `assertEquals(cursor.getMarkDeletedPosition(), 
PositionFactory.create(emptyLedgerId, -1))`. 
   
   Without this PR, the assert should be 
`assertEquals(cursor.getMarkDeletedPosition(), PositionFactory.create(p, 0))`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to