BewareMyPower commented on code in PR #25160:
URL: https://github.com/apache/pulsar/pull/25160#discussion_r2791154309
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -121,9 +123,11 @@ public void getList(
@ApiParam(value = "Specify the bundle name", required = false)
@QueryParam("bundle") String bundle,
@ApiParam(value = "Include system topic")
- @QueryParam("includeSystemTopic") boolean includeSystemTopic) {
+ @QueryParam("includeSystemTopic") boolean includeSystemTopic,
+ @ApiParam(value = "properties for customized topic listing plugin,
format: k1=v1,k2=v2")
+ @QueryParam("properties") String propertiesStr) {
Review Comment:
Why did you use a raw string and a manually written parse method
`parseProperties`? It seems to be possible to change the type to `Map<String,
String>` like `properties` in `updateSubscriptionProperties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
