coderzc commented on code in PR #25160:
URL: https://github.com/apache/pulsar/pull/25160#discussion_r2791191290
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -1269,6 +1279,14 @@ The max allowed delay for delayed delivery (in
milliseconds). If the broker rece
)
private boolean enableBrokerSideSubscriptionPatternEvaluation = true;
+ @FieldContext(
+ dynamic = false,
+ category = CATEGORY_POLICIES,
+ doc = "Enables watching topic add/remove events on broker side for
"
+ + "subscription pattern evaluation."
+ )
+ private boolean enableBrokerTopicListWatcher = true;
Review Comment:
The previous `enableSubscriptionPatternEvaluation` configuration had unclear
responsibilities, as it included the following two functions simultaneously:
1. Enable regular expression filtering on the server side
2. Enable Topic List Watch
I separated it into two configurations (enableSubscriptionPatternEvaluation
and enableBrokerTopicListWatcher), so that we can still use
`enableSubscriptionPatternEvaluation` to enable the server-side regular
expression filtering function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
