Denovo1998 opened a new pull request, #25767:
URL: https://github.com/apache/pulsar/pull/25767
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #xyz
<!-- or this PR is one task of an issue -->
Main Issue: #xyz
<!-- If the PR belongs to a PIP, please add the PIP link here -->
PIP: #xyz
<!-- Details of when a PIP is required and how the PIP process work, please
see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
This is a follow-up to #25625 for the replication read-failure path related
to #25097.
#25625 completes a replicator `InFlightTask` when a managed-ledger read
fails, so retryable read failures do not leave stale pending-read state behind.
However, there is still a race when the read failure callback arrives after the
replicator has already left `Started`, for example during termination or
producer restart. In that case, `readEntriesFailed` returns before clearing the
failed `InFlightTask`, leaving `entries == null` and causing `hasPendingRead()`
to continue treating the old read as active.
### Modifications
- Complete failed `InFlightTask` contexts before checking whether the
replicator is still in the `Started` state.
- Keep the cleanup defensive by only handling `InFlightTask` contexts whose
entries have not already been set.
- Remove duplicated failed-task completion from the later retry/error
branches in `readEntriesFailed`.
- Add a regression test that starts a real replication read, blocks the
managed-ledger read failure, terminates the replicator through the normal
lifecycle, releases the failure callback, and verifies the pending-read state
is cleared.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
