poorbarcode commented on PR #25767: URL: https://github.com/apache/pulsar/pull/25767#issuecomment-4458978920
Replicator termination only occurs in the two events of "disabling replication" and closing the topic, and these two events will trigger the JVM GC for the replicator object. So this PR only fixes the state of "pending reads" at the moment when "the topic is turned off, and the replicator object has not been GC", and the state "pending reads" at this moment will not cause any problems. However, this modification is still useful, which makes our project more perfect. I suggest changing the label in the title to "improve" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
