lhotari commented on code in PR #25871: URL: https://github.com/apache/pulsar/pull/25871#discussion_r3304577608
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -1,18 +1,26 @@ <!-- ### Contribution Checklist - - - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*. + + - PR title format should be *[type][component] summary*. The valid `[type]` and `[component]`/scope + prefixes are enforced by CI (see `.github/workflows/ci-semantic-pull-request.yml`); for details, + see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - + + - The **Motivation** and **Modifications** sections are required: explain *why* (the problem/context) Review Comment: many uses don't follow this at all. I hope that the chances are that they notice this detail when it's clearly stated. Some PRs are made without answering the simple question: why?. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
