lhotari commented on PR #25871:
URL: https://github.com/apache/pulsar/pull/25871#issuecomment-4554186035

   > * There are changed to the pull request template - I don't understand why, 
as it is unrelated to this PR and I don't get those changes in general.
   
   It's to make it aligned with other pull request guidance included in this 
PR. An additional motivation is to emphasis the essence of making sure that the 
PR contains the motivation which answers to the question "why?". I've seen that 
missing in many PRs.
   
   > * I personally would not place any skill like it is placed now. I think 
skill files should contain information relevant to the skill it self, and this 
info should not be copy pasted any where. It's good for us humans managing it, 
and a bit for the context size but it's not the real issue.
   > * Note that claude for example expects skills in `.claude/skills` and just 
mentioning we have skills in `agents.md` via `claude.md` symlink won't cut it 
according to what I read. This for example, I don't know if apache groovy guys 
checked.
   
   The skills serve a different purpose here and aren't intended to be used as 
slash commands for example in Claude Code. We can always revisit details in 
further PRs and improve it based on usage experiences.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to