wangjia007bond commented on a change in pull request #168:
[Issue-148][pulsar-client-go] add seek by messageID
URL: https://github.com/apache/pulsar-client-go/pull/168#discussion_r364552005
##########
File path: pulsar/consumer_impl.go
##########
@@ -319,6 +302,15 @@ func (c *consumer) Close() {
})
}
+func (c *consumer) Seek(msgID MessageID) error {
+ mid, ok := c.messageID(msgID)
+ if !ok {
+ return nil
Review comment:
I checked other interfaces like Ack and NackID, they didn't handle error,
because their interface didn't need return error, but I am not sure the correct
behavior here. so I follow the current way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
