wangjia007bond commented on a change in pull request #168:
[Issue-148][pulsar-client-go] add seek by messageID
URL: https://github.com/apache/pulsar-client-go/pull/168#discussion_r364552419
##########
File path: pulsar/consumer_impl.go
##########
@@ -364,3 +356,21 @@ func toProtoInitialPosition(p
SubscriptionInitialPosition) pb.CommandSubscribe_I
return pb.CommandSubscribe_Latest
}
+
+func (c *consumer) messageID(msgID MessageID) (*messageID, bool) {
Review comment:
I though this before, but this function will convert MessageID(uppercase M)
to messageID(lowercase m), so any function name like XXXMessageID, will cause
confusion...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
