zymap commented on a change in pull request #9225:
URL: https://github.com/apache/pulsar/pull/9225#discussion_r559554934
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -2011,6 +2011,18 @@ public int getMessageTTL(String topic) throws
PulsarAdminException {
}
}
+ @Override
+ public int getMessageTTLApplied(String topic) throws PulsarAdminException {
Review comment:
```suggestion
Integer getMessageTTL(String topic, boolean applied) throws
PulsarAdminException {
```
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1604,7 +1604,15 @@ void setDelayedDeliveryPolicy(String topic
* @throws PulsarAdminException
* Unexpected error
*/
- int getMessageTTL(String topic) throws PulsarAdminException;
+ Integer getMessageTTL(String topic) throws PulsarAdminException;
+
+ /**
+ * Get message TTL applied for a topic.
+ * @param topic
+ * @return
+ * @throws PulsarAdminException
+ */
+ int getMessageTTLApplied(String topic) throws PulsarAdminException;
Review comment:
```suggestion
Integer getMessageTTL(String topic, boolean applied) throws
PulsarAdminException;
```
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -2001,7 +2001,7 @@ public void setMessageTTL(String topic, int
messageTTLInSecond) throws PulsarAdm
}
@Override
- public int getMessageTTL(String topic) throws PulsarAdminException {
+ public Integer getMessageTTL(String topic) throws PulsarAdminException {
Review comment:
```suggestion
public Integer getMessageTTL(String topic) throws PulsarAdminException {
return getMessageTTL(topic, false);
```
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -1081,10 +1081,17 @@ void run() throws PulsarAdminException {
@Parameter(description = "persistent://tenant/namespace/topic",
required = true)
private java.util.List<String> params;
+ @Parameter(names = { "-ap", "--applied" }, description = "Get the
applied policy of the topic")
+ private boolean applied = false;
+
@Override
void run() throws PulsarAdminException {
String persistentTopic = validatePersistentTopic(params);
- print(admin.topics().getMessageTTL(persistentTopic));
+ if (applied) {
+ print(admin.topics().getMessageTTLApplied(persistentTopic));
+ } else {
+ print(admin.topics().getMessageTTL(persistentTopic));
+ }
Review comment:
```suggestion
print(admin.topics().getMessageTTL(persistentTopic, applied));
```
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -2011,6 +2011,18 @@ public int getMessageTTL(String topic) throws
PulsarAdminException {
}
}
+ @Override
+ public int getMessageTTLApplied(String topic) throws PulsarAdminException {
+ try {
+ TopicName topicName = validateTopic(topic);
+ WebTarget path = topicPath(topicName, "messageTTL");
+ path = path.queryParam("applied", true);
Review comment:
```suggestion
path = path.queryParam("applied", applied);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
