eolivelli commented on a change in pull request #9225:
URL: https://github.com/apache/pulsar/pull/9225#discussion_r559966114
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1604,7 +1604,15 @@ void setDelayedDeliveryPolicy(String topic
* @throws PulsarAdminException
* Unexpected error
*/
- int getMessageTTL(String topic) throws PulsarAdminException;
+ Integer getMessageTTL(String topic) throws PulsarAdminException;
Review comment:
this is a breaking change in the API,
code compiled for previous versions of Pulsar client will have to be
re-compiled.
And also this is a behaviour change, recompiling is not enough to apply the
new meaning of the value.
People who simply recompile will see NPE
I would not change this method and make it that returns the same value as
before.
we are adding the new method and that will be the right way.
Here we have to add a javadoc that explains the meaning of the result,
we could also deprecate this method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
