315157973 commented on a change in pull request #9225:
URL: https://github.com/apache/pulsar/pull/9225#discussion_r559984779
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1604,7 +1604,15 @@ void setDelayedDeliveryPolicy(String topic
* @throws PulsarAdminException
* Unexpected error
*/
- int getMessageTTL(String topic) throws PulsarAdminException;
+ Integer getMessageTTL(String topic) throws PulsarAdminException;
Review comment:
Methods with the same parameters and names cannot coexist. This is a
problem left over from history. If we want to switch completely smoothly, we
can add interfaces like admin.topicsV2(), admin.namespaceV2()...
If we modify the interface directly, users will know when upgrading the
SDK(It will definitely trigger a recompilation when upgrading the SDK), we need
to improve the doc of each interface, clarify the meaning of each return value
Please take a look here @sijie @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
