[GitHub] [pulsar] merlimat commented on a change in pull request #9802: [ISSUE 9783][pulsar-client] avoid create too many HashedWheelTimer instances

[GitBox]

merlimat commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r589600317



##########
File path: 
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
##########
@@ -18,6 +18,7 @@
  */
 package org.apache.pulsar.client.api;
 
+import io.netty.util.Timer;

Review comment:
       Additionally, `Timer` is not serializable and we need all classes in 
public API to be it:
   
   ```
   Medium: Class org.apache.pulsar.client.impl.conf.ClientConfigurationData 
defines non-transient non-serializable instance field timer 
[org.apache.pulsar.client.impl.conf.ClientConfigurationData] In 
ClientConfigurationData.java SE_BAD_FIELD
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org