eolivelli commented on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801760737
@codelipenghui @linlinnn @merlimat comment is > Instead, we could take a Timer instance from the PulsarClientImpl constructor and have the Pulsar proxy to pass it there. now the patch is only adding a way to pass a Timer to the PulsarClientImpl. I believe that the comment from Matteo is that is it okay to add a new constructor to PulsarClientImpl as far as it is only used in Pulsar codebase. This new constructor is not meant to be used by users (by code outside Pulsar internals) but it is not used by Pulsar itelft. I expect this patch to change Pulsar Proxy in order to use the new constructor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
