lhotari commented on a change in pull request #10961:
URL: https://github.com/apache/pulsar/pull/10961#discussion_r655138308
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1360,10 +1360,13 @@ public ShutdownService getShutdownService() {
return shutdownService;
}
+ public static String advertisedAddress(ServiceConfiguration config) {
Review comment:
Thanks for clarifying it @315157973 . However, this isn't clarified in
the code.
The original problem remains: there's the `PulsarService.advertisedAddress`
method which is almost the same as
`org.apache.pulsar.broker.ServiceConfigurationUtils.getAppliedAdvertisedAddress`
, but there's no description in the code why these are different and why
there's a need to have 2 separate methods.
It would be good to summarize this conversation in the javadocs & code
comments since that's what maintainers of the code will be reading.
Perhaps @Anonymitaet could help in documenting this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
