lhotari commented on a change in pull request #10961:
URL: https://github.com/apache/pulsar/pull/10961#discussion_r655224145
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1360,10 +1360,13 @@ public ShutdownService getShutdownService() {
return shutdownService;
}
+ public static String advertisedAddress(ServiceConfiguration config) {
Review comment:
> How about add such an method in `ServiceConfigurationUtils`?
>
> getAppliedAdvertisedAddress(ServiceConfiguration configuration, boolean
ignoreAdvertisedListener)
:+1: I think this could resolve the issue. Documenting the reason and
meaning of `ignoreAdvertisedListener` in javadoc would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
