danielsinai commented on pull request #11446:
URL: https://github.com/apache/pulsar/pull/11446#issuecomment-886206923


   The failed test actually found a bug that the first tryAcquire will always 
pass because the condition is running before the acquiredPermits changed, and 
that will let the producer to write 2x above the limit in the first try.
   
   In addition there are some tests that should failed like the test that fills 
all the permits in the first try - currently it asserting to true but actually 
we should assert it to false in order to throttle the producer in the first 
time the maximum permits are set.
   
   Ill publish a fix soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to