danielsinai commented on a change in pull request #11446:
URL: https://github.com/apache/pulsar/pull/11446#discussion_r676341281



##########
File path: 
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PublishRateLimiterTest.java
##########
@@ -104,9 +104,13 @@ public void testPrecisePublishRateLimiterAcquire() throws 
Exception {
 
         // tryAcquire msgSizeInBytes exceeded
         assertFalse(precisPublishLimiter.tryAcquire(10, 101));
-        Thread.sleep(1100);
+        Thread.sleep(2100);

Review comment:
       Would you like me to turn the rateLimiters within the 
precisPublishLimiter to public in order to call the renew function?
   
   Im afraid that it can result others to try and access the rateLimiters 
state, Oppositely to OOP mutable non-shared state approach




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to