BewareMyPower commented on a change in pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#discussion_r690239608
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3628,6 +3628,8 @@ private PersistentReplicator
getReplicatorReference(String replName, PersistentT
private CompletableFuture<Void> updatePartitionedTopic(TopicName
topicName, int numPartitions) {
final String path = ZkAdminPaths.partitionedTopicPath(topicName);
+ PartitionedTopicMetadata metadata =
getPartitionedTopicMetadata(topicName, false, false);
Review comment:
I think it's better to get partition metadata asynchronously here in
case deadlock might happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
