BewareMyPower commented on a change in pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#discussion_r690975274



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3636,6 +3636,15 @@ private PersistentReplicator 
getReplicatorReference(String replName, PersistentT
                         p -> new PartitionedTopicMetadata(numPartitions));
                 updatePartition.complete(null);
             } catch (Exception e) {
+                getPartitionedTopicMetadataAsync(topicName, false, 
false).thenAccept(metadata -> {
+                    int oldPartition = metadata.partitions;
+                    for(int i = oldPartition; i < numPartitions; i++){
+                        
namespaceResources().getPartitionedTopicResources().deleteAsync(ZkAdminPaths.managedLedgerPath(topicName.getPartition(i)));

Review comment:
       Should we add the error logs or retry when `deleteAsync` failed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to