wolfstudy commented on a change in pull request #660:
URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743352676



##########
File path: pulsar/negative_acks_tracker.go
##########
@@ -35,22 +35,41 @@ type negativeAcksTracker struct {
        doneOnce     sync.Once
        negativeAcks map[messageID]time.Time
        rc           redeliveryConsumer
-       tick         *time.Ticker
+       nackBackoff  NackBackoffPolicy
+       trackFlag    bool
        delay        time.Duration
        log          log.Logger
 }
 
-func newNegativeAcksTracker(rc redeliveryConsumer, delay time.Duration, logger 
log.Logger) *negativeAcksTracker {
-       t := &negativeAcksTracker{
-               doneCh:       make(chan interface{}),
-               negativeAcks: make(map[messageID]time.Time),
-               rc:           rc,
-               tick:         time.NewTicker(delay / 3),
-               delay:        delay,
-               log:          logger,
-       }
+func newNegativeAcksTracker(rc redeliveryConsumer, delay time.Duration,
+       nackBackoffPolicy NackBackoffPolicy, logger log.Logger) 
*negativeAcksTracker {
+
+       t := new(negativeAcksTracker)

Review comment:
       They are the same effect




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to