[GitHub] [pulsar] Jason918 commented on a change in pull request #12869: [PIP-105] Part-1 Support add subscription properties

[GitBox]

Jason918 commented on a change in pull request #12869:
URL: https://github.com/apache/pulsar/pull/12869#discussion_r753812012



##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -382,6 +382,8 @@ message CommandSubscribe {
     optional uint64 start_message_rollback_duration_sec = 16 [default = 0];
 
     optional KeySharedMeta keySharedMeta = 17;
+
+    repeated KeyLongValue subscription_properties = 18;

Review comment:
       It should be optional ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org