[GitHub] [pulsar] 315157973 commented on a change in pull request #12869: [PIP-105] Part-1 Support add subscription properties

[GitBox]

315157973 commented on a change in pull request #12869:
URL: https://github.com/apache/pulsar/pull/12869#discussion_r754006804



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##########
@@ -137,6 +137,13 @@ default boolean isMarkerMessage() {
                                           long 
startMessageRollbackDurationSec, boolean replicateSubscriptionState,
                                           KeySharedMeta keySharedMeta);
 
+    /**
+     * Subscribe a topic.
+     * @param option
+     * @return
+     */
+    CompletableFuture<Consumer> subscribe(SubscriptionOption option);

Review comment:
       Deleting the interface is not good, I first set it to @Deprecated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org