[GitHub] [pulsar] codelipenghui commented on a change in pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

[GitBox]

codelipenghui commented on a change in pull request #12872:
URL: https://github.com/apache/pulsar/pull/12872#discussion_r754302614



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -1322,7 +1322,7 @@ public void createSubscription(
                     defaultValue = "latest",
                     allowableValues = "latest, earliest, ledgerId:entryId"
             )
-                    MessageIdImpl messageId,
+                    ResetCursorData resetCursorData,

Review comment:
       Oh, Sorry @RobertIndie my mistake, it looks like we already have 
`messageId` there, changing to resetCursorData will introduce compatibility 
issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org