[GitHub] [pulsar] RobertIndie commented on a change in pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

[GitBox]

RobertIndie commented on a change in pull request #12872:
URL: https://github.com/apache/pulsar/pull/12872#discussion_r755626872



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -1322,7 +1322,7 @@ public void createSubscription(
                     defaultValue = "latest",
                     allowableValues = "latest, earliest, ledgerId:entryId"
             )
-                    MessageIdImpl messageId,
+                    ResetCursorData resetCursorData,

Review comment:
       This is the REST API. The Json format of the `ResetCursorData` and 
`MessageIdImpl` used here is the same. It looks like there are no compatibility 
issues here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org