rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more
secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#discussion_r161096455
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
##########
@@ -35,6 +35,14 @@
// ZooKeeper session timeout
private int zookeeperSessionTimeoutMs = 30_000;
+ // If Discovery Service is Disabled the proxy will just authenticate the
client
+ // and forward all requests to a VIP or any other service discovery port
+ private boolean discoveryServiceEnabled = true;
+
+ // if Service Discovery is Disabled this url should point to the discovery
service provider.
+ private String discoveryServiceURL = "pulsar://localhost:6650/";
Review comment:
should we rename it to `brokerServiceUrl` as in this case proxy will
directly try to communicate broker with brokerserviceUrl?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
