rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more
secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#discussion_r161094006
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
##########
@@ -35,6 +35,14 @@
// ZooKeeper session timeout
private int zookeeperSessionTimeoutMs = 30_000;
+ // If Discovery Service is Disabled the proxy will just authenticate the
client
+ // and forward all requests to a VIP or any other service discovery port
+ private boolean discoveryServiceEnabled = true;
Review comment:
I think we might not need this flag? If global-zk address is not provided
then proxy should fall to provided discovery-url? similar as what we have done
for websocket `WebSocketProxyConfiguration.java`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
