jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164589275
########## File path: pulsar-client-cpp/lib/ConsumerConfigurationImpl.h ########## @@ -31,13 +31,18 @@ struct ConsumerConfigurationImpl { int receiverQueueSize; std::string consumerName; long brokerConsumerStatsCacheTimeInMs; + CryptoKeyReader* cryptoKeyReader; Review comment: Can we use shared pointer instead like we do for MessageRouter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services