jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164591461
########## File path: pulsar-client-cpp/lib/ProducerImpl.cc ########## @@ -50,7 +50,9 @@ ProducerImpl::ProducerImpl(ClientImplPtr client, const std::string& topic, const producerStr_("[" + topic_ + ", " + producerName_ + "] "), producerId_(client->newProducerId()), msgSequenceGenerator_(0), - sendTimer_() { + sendTimer_(), + msgCrypto_(), + dataKeyGenInterval_(4 * 60 * 60) { Review comment: dataKeyGenIntervalInMs_ (time unit missing) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services